Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chart Testing Composite #116

Merged
merged 29 commits into from
Jun 12, 2024
Merged

Conversation

tylertitsworth
Copy link
Contributor

@tylertitsworth tylertitsworth commented Jun 10, 2024

Description

Create composite action for helm chart testing in any repo.

Related Issue

MLOPS-2000

Changes Made

  • Introduce workflows/charts/action.yml
  • Modify chart-ci.yaml to use the new composite
  • The code follows the project's coding standards.
  • No Intel Internal IP is present within the changes.
  • The documentation has been updated to reflect any changes in functionality.

Validation

https://github.com/intel/ai-containers/actions/runs/9454764791/job/26043056846
https://github.com/intel/ai-containers/actions/runs/9454532027/job/26042280150

  • I have tested any changes in container groups locally with test_runner.py with all existing tests passing, and I have added new tests where applicable.

@tylertitsworth tylertitsworth added the WIP Work in Progress label Jun 10, 2024
@tylertitsworth tylertitsworth self-assigned this Jun 10, 2024
Copy link

github-actions bot commented Jun 10, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 4 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/chart-ci.yaml

PackageVersionLicenseIssue Type
intel/ai-containers/workflows/charts3dd3db5NullUnknown License

.github/workflows/integration-test.yaml

PackageVersionLicenseIssue Type
intel/ai-containers/.github/workflows/container-ci.yaml3dd3db5NullUnknown License

.github/workflows/weekly-test.yaml

PackageVersionLicenseIssue Type
intel/ai-containers/.github/workflows/container-ci.yaml3dd3db5NullUnknown License
intel/ai-containers/workflows/charts3dd3db5NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
actions/azure/setup-kubectl 3e0aec4d80787158d308d7b364cb1b702e7feb7f UnknownUnknown
actions/intel/ai-containers/workflows/charts 3dd3db5 🟢 8.5
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 1028 out of 28 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices🟢 5badge detected: Passing
Code-Review🟢 8Found 17/20 approved changesets -- score normalized to 8
Contributors🟢 10project has 15 contributing companies or organizations
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
SAST🟢 8SAST tool is not run on all commits -- score normalized to 8
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 100 existing vulnerabilities detected
actions/actions/setup-python 82c7e631bb3cdc910f68e0081d67478d79c6982d 🟢 5.4
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 32 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 3
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
Security-Policy🟢 9security policy file detected
SAST🟢 10SAST tool is run on all commits
Vulnerabilities⚠️ 048 existing vulnerabilities detected
actions/azure/setup-helm fe7b79cd5ee1e45176fcad797de68ecaf3ca4814 UnknownUnknown
actions/helm/chart-testing-action e6669bcd63d7cb57cb4380c33043eebe5d111992 🟢 5.3
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 34 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 3
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
actions/intel/ai-containers/.github/workflows/container-ci.yaml 3dd3db5 🟢 8.5
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 1028 out of 28 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices🟢 5badge detected: Passing
Code-Review🟢 8Found 17/20 approved changesets -- score normalized to 8
Contributors🟢 10project has 15 contributing companies or organizations
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
SAST🟢 8SAST tool is not run on all commits -- score normalized to 8
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 100 existing vulnerabilities detected
actions/intel/ai-containers/.github/workflows/container-ci.yaml 3dd3db5 🟢 8.5
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 1028 out of 28 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices🟢 5badge detected: Passing
Code-Review🟢 8Found 17/20 approved changesets -- score normalized to 8
Contributors🟢 10project has 15 contributing companies or organizations
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
SAST🟢 8SAST tool is not run on all commits -- score normalized to 8
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 100 existing vulnerabilities detected
actions/intel/ai-containers/workflows/charts 3dd3db5 🟢 8.5
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 1028 out of 28 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices🟢 5badge detected: Passing
Code-Review🟢 8Found 17/20 approved changesets -- score normalized to 8
Contributors🟢 10project has 15 contributing companies or organizations
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
SAST🟢 8SAST tool is not run on all commits -- score normalized to 8
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 100 existing vulnerabilities detected
actions/step-security/harden-runner f086349bfa2bd1361f7909c78558e816508cdc10 🟢 8.8
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
CI-Tests🟢 1015 out of 15 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Code-Review🟢 10all changesets reviewed
Contributors🟢 62 different organizations found -- score normalized to 6
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1017 commit(s) out of 30 and 2 issue activity out of 30 found in the last 90 days -- score normalized to 10
Packaging⚠️ -1no published package detected
Pinned-Dependencies🟢 7dependency not pinned by hash detected -- score normalized to 7
SAST🟢 10SAST tool is run on all commits
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 10no vulnerabilities detected

Scanned Manifest Files

.github/workflows/chart-ci.yaml
.github/workflows/integration-test.yaml
.github/workflows/weekly-test.yaml

@tylertitsworth tylertitsworth added Review and removed WIP Work in Progress labels Jun 10, 2024
@tylertitsworth tylertitsworth changed the base branch from main to tylertitsworth/integration-test-depth June 10, 2024 20:19
sharvil10
sharvil10 previously approved these changes Jun 11, 2024
Copy link
Contributor

@sharvil10 sharvil10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharvil10 sharvil10 self-requested a review June 11, 2024 16:14
@sharvil10 sharvil10 dismissed their stale review June 11, 2024 16:15

Need to wait for other branch

@tylertitsworth tylertitsworth changed the base branch from tylertitsworth/integration-test-depth to main June 11, 2024 16:24
@tylertitsworth tylertitsworth enabled auto-merge June 11, 2024 16:27
sharvil10
sharvil10 previously approved these changes Jun 11, 2024
Copy link
Contributor

@sharvil10 sharvil10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylertitsworth tylertitsworth added this pull request to the merge queue Jun 11, 2024
@tylertitsworth tylertitsworth removed this pull request from the merge queue due to a manual request Jun 11, 2024
@tylertitsworth tylertitsworth changed the title Create chart-testing Composite Use Chart Testing Composite Jun 11, 2024
@tylertitsworth tylertitsworth changed the base branch from main to tylertitsworth/chart-composite June 11, 2024 17:44
@tylertitsworth tylertitsworth changed the base branch from tylertitsworth/chart-composite to main June 11, 2024 19:20
@tylertitsworth tylertitsworth dismissed sharvil10’s stale review June 11, 2024 19:20

The base branch was changed.

@tylertitsworth tylertitsworth enabled auto-merge June 11, 2024 20:17
@sharvil10 sharvil10 self-requested a review June 12, 2024 17:30
Copy link
Contributor

@sharvil10 sharvil10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylertitsworth tylertitsworth added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit ffb638e Jun 12, 2024
9 checks passed
@tylertitsworth tylertitsworth deleted the tylertitsworth/ct-composite branch June 13, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants