-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Chart Testing Composite #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency ReviewThe following issues were found:
License Issues.github/workflows/chart-ci.yaml
.github/workflows/integration-test.yaml
.github/workflows/weekly-test.yaml
OpenSSF Scorecard
Scanned Manifest Files.github/workflows/chart-ci.yaml.github/workflows/integration-test.yaml.github/workflows/weekly-test.yaml |
Signed-off-by: Tyler Titsworth <[email protected]>
tylertitsworth
changed the base branch from
main
to
tylertitsworth/integration-test-depth
June 10, 2024 20:19
sharvil10
previously approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tylertitsworth
changed the base branch from
tylertitsworth/integration-test-depth
to
main
June 11, 2024 16:24
Signed-off-by: Tyler Titsworth <[email protected]>
sharvil10
previously approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Tyler Titsworth <[email protected]>
tylertitsworth
changed the title
Create chart-testing Composite
Use Chart Testing Composite
Jun 11, 2024
tylertitsworth
changed the base branch from
main
to
tylertitsworth/chart-composite
June 11, 2024 17:44
tylertitsworth
changed the base branch from
tylertitsworth/chart-composite
to
main
June 11, 2024 19:20
sharvil10
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create composite action for helm chart testing in any repo.
Related Issue
MLOPS-2000
Changes Made
workflows/charts/action.yml
chart-ci.yaml
to use the new compositeValidation
https://github.com/intel/ai-containers/actions/runs/9454764791/job/26043056846
https://github.com/intel/ai-containers/actions/runs/9454532027/job/26042280150
test_runner.py
with all existing tests passing, and I have added new tests where applicable.