Skip to content

Commit

Permalink
fix lint issues
Browse files Browse the repository at this point in the history
Signed-off-by: tylertitsworth <[email protected]>
  • Loading branch information
tylertitsworth committed Jul 3, 2024
1 parent 191f891 commit 83774ad
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 7 deletions.
8 changes: 4 additions & 4 deletions pytorch/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ RUN mkdir -p /var/run/sshd && \

ARG PYTHON_VERSION

COPY generate_ssh_keys.sh .
COPY multinode/generate_ssh_keys.sh .

# modify generate_ssh_keys to be a helper script
# print how to use helper script on bash startup
Expand All @@ -117,9 +117,9 @@ RUN echo "source /usr/local/lib/python${PYTHON_VERSION}/dist-packages/oneccl_bin
cat '/generate_ssh_keys.sh' >> ~/.startup && \
rm -rf /generate_ssh_keys.sh

COPY dockerd-entrypoint.sh /usr/local/bin/dockerd-entrypoint.sh
COPY sshd_config /etc/ssh/sshd_config
COPY ssh_config /etc/ssh/ssh_config
COPY multinode/dockerd-entrypoint.sh /usr/local/bin/dockerd-entrypoint.sh
COPY multinode/sshd_config /etc/ssh/sshd_config
COPY multinode/ssh_config /etc/ssh/ssh_config

RUN mkdir -p /licensing

Expand Down
6 changes: 4 additions & 2 deletions pytorch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,15 @@ To add these files correctly please follow the steps described below.
chmod 600 id_rsa config authorized_keys
chown root:root id_rsa.pub id_rsa config authorized_keys
```

3. Setup hostfile. The hostfile is needed for running torch distributed using `ipexrun` utility. If you're not using `ipexrun` you can skip this step.
```txt
<Host 1 IP/Hostname>
<Host 2 IP/Hostname>
...
```
4. Now start the workers and execute DDP on the launcher.
1. Worker run command:
Expand All @@ -168,7 +170,7 @@ To add these files correctly please follow the steps described below.
bash -c '/usr/sbin/sshd -D'
```
3. Launcher run command:
2. Launcher run command:
```bash
docker run -it --rm \
Expand All @@ -181,7 +183,7 @@ To add these files correctly please follow the steps described below.
bash -c 'ipexrun cpu --nnodes 2 --nprocs-per-node 1 --master-addr 127.0.0.1 --master-port 3022 /workspace/tests/ipex-resnet50.py --ipex --device cpu --backend ccl'
```
4. Start SSH server with a custom port.
5. Start SSH server with a custom port.
If the user wants to define their own port to start the SSH server, it can be done so using the commands described below.
1. Worker command:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

set -e
set -a
source ~/.startup
# shellcheck disable=SC1091
source "$HOME/.startup"
set +a
"$@"
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 83774ad

Please sign in to comment.