Fix debug migtd image build #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable debug profile for migtd binary only. This can minimize the size of the `BFV` region. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0306/adjust_image_layout
branch
from
29d6da3 to
0fdf145
Compare
gaojiaqi7
force-pushed
the
0306/adjust_image_layout
branch
2 times, most recently
from
22166b7 to
2955f39
Compare
gaojiaqi7
force-pushed
the
0306/adjust_image_layout
branch
2 times, most recently
from
6c9b9b6 to
eebe30f
Compare
jyao1
reviewed
Mar 8, 2024
src/migtd/src/config.rs
Outdated
| @@ -6,7 +6,7 @@ use r_efi::efi::Guid; | |||
| use td_uefi_pi::{fv, pi}; | |||
|
|
|||
| pub const CONFIG_VOLUME_BASE: usize = 0xFF000000; | |||
| pub const CONFIG_VOLUME_SIZE: usize = 0x40000; | |||
| pub const CONFIG_VOLUME_SIZE: usize = 0x20000; | |||
There was a problem hiding this comment.
why we need change this? Everything should be in image_layout.json.
gaojiaqi7
force-pushed
the
0306/adjust_image_layout
branch
from
eebe30f to
41aff84
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gaojiaqi7
force-pushed
the
0306/adjust_image_layout
branch
from
41aff84 to
50e2307
Compare
Migtd using new attestation library requires more image spaces for debug build. Ajusts the `CFV, `TempRam` and `Ipl` size based on current status to get more space for the `Payload` region. Signed-off-by: Jiaqi Gao <[email protected]>
Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0306/adjust_image_layout
branch
from
50e2307 to
e2c0881
Compare
jyao1
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payload