Skip to content

Commit

Permalink
acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes
Browse files Browse the repository at this point in the history
WARNING: Avoid logging continuation uses where feasible
torvalds#54: FILE: drivers/acpi/numa/hmat.c:768:
+	pr_cont("read_latency: %u, write_latency: %u, read_bandwidth: %u, write_bandwidth: %u\n",

WARNING: __meminitdata should be placed after hmat_adist_nb
torvalds#174: FILE: drivers/acpi/numa/hmat.c:888:
+static __meminitdata struct notifier_block hmat_adist_nb =

ERROR: that open brace { should be on the previous line
torvalds#175: FILE: drivers/acpi/numa/hmat.c:889:
+static __meminitdata struct notifier_block hmat_adist_nb =
+{

WARNING: From:/Signed-off-by: email name mismatch: 'From: Huang Ying <[email protected]>' != 'Signed-off-by: "Huang, Ying" <[email protected]>'

total: 1 errors, 3 warnings, 185 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/acpi-hmat-calculate-abstract-distance-with-hmat.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: "Huang, Ying" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
akpm00 committed Aug 15, 2023
1 parent 7c6d8ef commit 21e812d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/acpi/numa/hmat.c
Original file line number Diff line number Diff line change
Expand Up @@ -885,8 +885,7 @@ static int hmat_calculate_adistance(struct notifier_block *self,
return NOTIFY_STOP;
}

static __meminitdata struct notifier_block hmat_adist_nb =
{
static __meminitdata struct notifier_block hmat_adist_nb = {
.notifier_call = hmat_calculate_adistance,
.priority = 100,
};
Expand Down

0 comments on commit 21e812d

Please sign in to comment.