Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix topic regex to allow single characters #996

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

sdomula
Copy link
Contributor

@sdomula sdomula commented Dec 3, 2021

The regex introduced with #951 does not match with single alphanumeric character topics, e.g., "r" and "2". But those are valid topics.

@danielpops
Copy link
Contributor

Fixes #999

Copy link
Contributor

@danielpops danielpops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably not qualified to approve, but this lgtm! :)

@lopopolo
Copy link

lopopolo commented Dec 4, 2021

I ran into this on https://github.com/topics/c.

@jcudit jcudit merged commit d2d39f8 into integrations:main Dec 13, 2021
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants