-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add branches
attribute to github_repository
#892
Conversation
a5fdcfa
to
648dde7
Compare
648dde7
to
740899b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a test added or modified to incorporate the new field? Otherwise looks 👌🏾 with the docs update and implementation!
@jcudit I've only seen tests around for more advanced stuff like resource modification and nontrivial logic, so I figured we don't normally test simple things like this. I'll have another look though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after verifying locally:
STATE:
data.github_repository.test:
ID = tf-acc-hgsf1
provider = provider.github
allow_merge_commit = true
allow_rebase_merge = true
allow_squash_merge = true
archived = false
branches.# = 1
branches.0.name = main
branches.0.protected = false
Thank you for finalising this, I got distracted by other things unfortunately. |
Is this released? It's in the documentation but I'm getting an error when trying to use it just now (Terraform v1.0.3 and integrations/terraform-provider-github v4.17.0):
|
In integrations#892, the newly-added `branches` attribute was exported for the data source, but not the resource. This exports `branches` in the resource too.
In #892, the newly-added `branches` attribute was exported for the data source, but not the resource. This exports `branches` in the resource too.
In integrations#892, the newly-added `branches` attribute was exported for the data source, but not the resource. This exports `branches` in the resource too.
Addresses #748.
Adding
branches
to both the resource and the data source.