Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/repository_file: ignore commit-related fields during acctest import step #491

Closed
wants to merge 1 commit into from

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 14, 2020

Addresses test failures since commit info is no longer set in Read per #466:

--- FAIL: TestAccGithubRepositoryFile_basic (15.20s)
    testing.go:654: Step 2 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=3) {
         (string) (len=13) "commit_author": (string) (len=9) "Test User",
         (string) (len=12) "commit_email": (string) (len=60) "[email protected]",
         (string) (len=14) "commit_message": (string) (len=34) "Update tf-acc-test-file-7r6ww6pfrt"
        }
--- FAIL: TestAccGithubRepositoryFile_branch (12.28s)
    testing.go:654: Step 2 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=3) {
         (string) (len=13) "commit_author": (string) (len=9) "Test User",
         (string) (len=12) "commit_email": (string) (len=60) "[email protected]",
         (string) (len=14) "commit_message": (string) (len=34) "Update tf-acc-test-file-u2iquispnf"
        }
--- FAIL: TestAccGithubRepositoryFile_committer (15.33s)
    testing.go:654: Step 2 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=3) {
         (string) (len=13) "commit_author": (string) (len=14) "Terraform User",
         (string) (len=12) "commit_email": (string) (len=21) "[email protected]",
         (string) (len=14) "commit_message": (string) (len=20) "Managed by Terraform"
        }

@ghost ghost added the size/XS label Jun 14, 2020
@anGie44 anGie44 changed the title resource/repository_file: ignore commit-related fields during import step resource/repository_file: ignore commit-related fields during acctest import step Jun 14, 2020
@nickfloyd nickfloyd added the Status: Stale Used by stalebot to clean house label Nov 30, 2022
@nickfloyd
Copy link
Contributor

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Sep 6, 2023
@github-actions github-actions bot closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Status: Stale Used by stalebot to clean house
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants