Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Add insecure mode #48

Merged
merged 3 commits into from
Aug 7, 2018

Conversation

georgecodes
Copy link

Added a config option to allow use against a GitHub Enterprise installation with self-signed certificates.

@radeksimko radeksimko added the Type: Feature New feature or request label Sep 14, 2017
@majormoses
Copy link
Contributor

needs a rebase to fix conflicts. To be honest I don't find a lot of value doing this as it is super easy to get a trusted cert for free these days and not verifying a cert is basically as bad as not having one. I would think it better to be able to provide a path locally to your certs so it can at least validate that way. Just my $0.02.

@radeksimko radeksimko changed the title Add insecure mode provider: Add insecure mode Aug 2, 2018
@radeksimko
Copy link
Contributor

Hi @georgecodes
thank you for your PR and sorry for the long delay in processing it.

Given the age of this PR, I took the liberty and made some changes to:

  1. decouple some of the logic and remove unused (commented out) code
  2. add a test which exercises this new option for both cases (insecure = true/false)
  3. reflect @majormoses's valid comments in docs

I hope you're 👌 with these changes. Your authorship was retained, so your commit will still be credited to you.

With that I'm going to merge this PR, so we can make it part of the next release.

@radeksimko radeksimko merged commit e12f65a into integrations:master Aug 7, 2018
@georgecodes
Copy link
Author

Thanks very much!

kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Provider Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants