Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only enable dismissal restrictions if users or teams provided #453

Merged
merged 3 commits into from
May 15, 2020
Merged

only enable dismissal restrictions if users or teams provided #453

merged 3 commits into from
May 15, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 10, 2020 •
edited
Loading

Output of acceptance tests:

--- PASS: TestAccGithubBranchProtection_users (12.96s)
--- PASS: TestAccGithubBranchProtection_emptyDismissalRestrictions (19.08s)
--- PASS: TestAccGithubBranchProtection_emptyItems (19.16s)
--- PASS: TestAccGithubBranchProtection_basic (35.05s)
--- PASS: TestAccGithubBranchProtection_teams (56.88s)

@ghost ghost added the size/M label May 10, 2020
@anGie44 anGie44 linked an issue May 10, 2020 that may be closed by this pull request
Enabling require_code_owner_reviews also enables dismissal_restrictions #267
Closed
@anGie44 anGie44 requested a review from jcudit May 12, 2020 14:27
@anGie44 anGie44 merged commit 5ae8c3e into master May 15, 2020
@anGie44 anGie44 added this to the v2.8.0 milestone May 15, 2020
anGie44 added a commit that referenced this pull request May 15, 2020
@anGie44
Update CHANGELOG for #453
b718e19
@anGie44 anGie44 deleted the ap_branch_protection_dismissals branch June 18, 2020 05:55
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@anGie44
Merge pull request integrations#453 from terraform-providers/ap_branc…
6d799aa 
…h_protection_dismissals

only enable dismissal restrictions if users or teams provided
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@anGie44
Update CHANGELOG for integrations#453
051be8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcudit jcudit jcudit approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

Enabling require_code_owner_reviews also enables dismissal_restrictions
2 participants
@anGie44 @jcudit