fix: Ensure integration_id is treated as optional and nil #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Danielku15
force-pushed
the
fix-issue-2317
branch
from
83c50b6 to
ca6886c
Compare
|
Update: Beside the integration test I also tested this change against our GHES installation where I confirmed its working as expected. |
|
Seems our GHES 3.14 was behavior strangely different to GitHub.com and GHES 3.15. As we upgraded last week I can successfully create rulesets using the currently released provider. With this I'm not fully sure if my PR addresses the linked problem in the right way, hence I'm better closing it to avoid confusion. 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2317
Before the change?
integration_iddespite being optional was filled with0and expected to be filled everywhere causing API validation errors.After the change?
integration_iddefualt values were removed and respective places where adapted to handlenil(and potential0) values.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!