Add a data source for refs. #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youcandanch
force-pushed
the
data-source-ref
branch
from
78f25e3 to
c2b74ff
Compare
|
@kfcampbell this one's probably simpler to land then #1066, which I haven't had as much time to work on. Any chance you could kick the workflows for this as well? Thanks so much! |
|
@youcandanch Done! Do you also mind linking to the sweet new docs page you just created in the .erb file? Thanks! |
youcandanch
force-pushed
the
data-source-ref
branch
from
c2b74ff to
1209d3e
Compare
youcandanch
force-pushed
the
data-source-ref
branch
from
1209d3e to
49fedbd
Compare
|
@kfcampbell all set! |
kfcampbell
approved these changes
Mar 22, 2022
|
@kfcampbell looks like an older commit of mine made it up here, which means there's some errors in the ref code. I'm gonna fix it, but I'm also gonna glance and see why tests were able to pass, as I don't think there's a way they should be passing right now. Issue opened here: #1108 |
kfcampbell
added a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
Co-authored-by: Keegan Campbell <[email protected]>
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
Co-authored-by: Keegan Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're currently lacking a way to retrieve some basic information on a given ref within the Terraform provider. A crisp use case for this might be "I have a release that's based off of a tag, and I'd like to be able to retrieve the SHA1 for the HEAD commit in order to use elsewhere." This PR introduces a
github_refdata source, which pretty shamelessly steals from the existinggithub_branchdata source. I considered lifting out some of the code into a shared function, but the API calls are lightweight enough where I don't think there's that much harm from a few lines of duplication.Tests are currently passing and documentation has been added to the markdown.