-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for allow_forking on a repository/update to go-github v42 #1033
Support for allow_forking on a repository/update to go-github v42 #1033
Conversation
@diogopms I've merged the latest Are you okay with these changes as-is? If so, I can get them merged. If not, let's talk about it! |
👍🏻 looks good let's merge it , thanks for fixing it 🙏🏻 cc @kfcampbell |
@kfcampbell and @diogopms This change is exhibiting odd behaviour and may need to be fixed or reverted. As per issue #1136. Also, for some reason the website docs have not been updated to reflect this new field, even though they are changed in this push. Happy to help if I can? |
@jaredfholgate I've reverted this PR and published v4.24.1 with only that change in it. If you'd like to take a stab at fixing the behavior, I'd be happy to review it! |
…tegrations#1033) * updating go-github to v42 * support for allow_forking field * Make allow_forking optional; default to true * Default allow_forking to true in resource Co-authored-by: Keegan Campbell <[email protected]>
What would be the desired behaviour? Should the implementation first check whether forking has been disabled on org level and in such a case do nothing? Is that feasible? I am not familiar with this provider but would really like to have the allow_forking support in the provider. |
…tegrations#1033) * updating go-github to v42 * support for allow_forking field * Make allow_forking optional; default to true * Default allow_forking to true in resource Co-authored-by: Keegan Campbell <[email protected]>
Support enabling/disabling allow_forking on a repository as per #353
More info on the Github Public API
Waiting from go-github to create a release on this PR:
google/go-github#2256