-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking behavior in 2.9.0 release: terraform validate fails because of missing token #503
Comments
I'd say this is related to https://github.com/terraform-providers/terraform-provider-github/issues/502 since the token was required unless The fix for now is to pin the provider to the previous release, 2.8.1. |
We provide a module and run automated tests for static analysis and unit testing. The static analysis runs tools like
(crossposted from #464) to clarify the details. |
Added #502 to the list of references, thanks. For this specific issue, we worked around by setting the TOKEN via environment variables also for the validation step. |
Here's how I'm using the provider "github" {
anonymous = true
individual = true
}
data "github_ip_ranges" "default" {} I'm using the ip ranges returned by that data block to give GitHub hooks access to my API. I'm not setting the token using an environment variable. |
Changes to unblock this are now merged into the default branch. With the v3.0.0 release likely landing mid next week. |
Hello, the v3.0.0 release is out, does it mean that this bug is fixed ? |
Yes, this should be resolved in the latest release. Please re-open if there are further issues. |
Thi bug is not fix. I still see the bug
|
Hi there,
As mentioned here https://github.com/terraform-providers/terraform-provider-github/pull/464#issuecomment-651254293, we are facing breaking behavior in a minor release.
We applied the workaround mentioned below and are fine for now, but I want to raise the issue anyway as we faced this in our automated testing of the github open-source modules we provide at @mineiros-io to make managing github configuration easy.
Terraform & Provider Version
Affected Resource(s)
Terraform Configuration Files
N/A
Debug Output
With
2.8.1
terraform validate
in our module code validates just fine. With2.9.0
we get the following breaking error now:Expected Behavior
terraform validate
just run fine without carping about a missingtoken
.Actual Behavior
terraform validate
fails withThe argument "token" is required, but was not set.
GITHUB_TOKEN
environment to a random string fixes the behavior.Steps to Reproduce
terraform validate
without specifying a token configuration with 2.8.1 and 2.9.0References
The issue was raised before in the introducing PR introducing the breaking change:
The text was updated successfully, but these errors were encountered: