fix: error if autolink reference not found (#2164)

* fix: error if autolink reference not found * Add test for importing an invalid key --------- Co-authored-by: Nick Floyd <[email protected]> Co-authored-by: Keegan Campbell <[email protected]>
integrations · Mar 8, 2024 · 4cebab8 · 4cebab8
1 parent 39c5e06
commit 4cebab8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/github/repository_utils.go b/github/repository_utils.go
@@ -98,7 +98,7 @@ func getAutolinkByKeyPrefix(client *github.Client, owner, repo, keyPrefix string
 		}
 	}
 
-	return nil, nil
+	return nil, fmt.Errorf("cannot find autolink reference %s in repo %s/%s", keyPrefix, owner, repo)
 }
 
 // listAutolinks returns all autolink references for the given repository.

diff --git a/github/resource_github_repository_autolink_reference_test.go b/github/resource_github_repository_autolink_reference_test.go
@@ -2,6 +2,7 @@ package github
 
 import (
 	"fmt"
+	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
@@ -288,6 +289,12 @@ func TestAccGithubRepositoryAutolinkReference(t *testing.T) {
 						ImportStateVerify: true,
 						ImportStateId:     fmt.Sprintf("oof-%s/OOF-", randomID),
 					},
+					{
+						ResourceName:  "github_repository_autolink_reference.autolink",
+						ImportState:   true,
+						ImportStateId: fmt.Sprintf("oof-%s/OCTOCAT-", randomID),
+						ExpectError:   regexp.MustCompile(`cannot find autolink reference`),
+					},
 				},
 			})
 		}
-Original file line number
+Diff line change
@@ Expand Up @@
     		}
     	}
-    	return nil, nil
+    	return nil, fmt.Errorf("cannot find autolink reference %s in repo %s/%s", keyPrefix, owner, repo)
     }
     // listAutolinks returns all autolink references for the given repository.
@@ Expand Down @@