Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just adding xarray image plugin #28

Merged
merged 5 commits into from
Jan 15, 2019
Merged

Just adding xarray image plugin #28

merged 5 commits into from
Jan 15, 2019

Conversation

jsignell
Copy link
Member

Supersedes #25; just adds image plugin without doing the refactor

Copy link
Member

@martindurant martindurant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is indeed the way to go. Not a huge amount of code duplication, really.
My comments are mostly around moving docstrings.

(have not looked at notebook yet)

intake_xarray/image.py Outdated Show resolved Hide resolved
intake_xarray/image.py Outdated Show resolved Hide resolved
intake_xarray/image.py Show resolved Hide resolved
intake_xarray/image.py Outdated Show resolved Hide resolved
intake_xarray/image.py Show resolved Hide resolved
intake_xarray/image.py Show resolved Hide resolved
intake_xarray/image.py Show resolved Hide resolved
intake_xarray/image.py Show resolved Hide resolved
intake_xarray/image.py Show resolved Hide resolved
tests/test_intake_xarray.py Show resolved Hide resolved
@jsignell
Copy link
Member Author

Ok I think this is ready. @martindurant any more feedback/qualms?

@martindurant
Copy link
Member

Sorry, @jsignell , comments went through individually this time :|

@martindurant martindurant merged commit 292137b into master Jan 15, 2019
@jsignell jsignell deleted the jsignell/image2 branch January 15, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants