-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just adding xarray image plugin #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is indeed the way to go. Not a huge amount of code duplication, really.
My comments are mostly around moving docstrings.
(have not looked at notebook yet)
Ok I think this is ready. @martindurant any more feedback/qualms? |
Sorry, @jsignell , comments went through individually this time :| |
Supersedes #25; just adds image plugin without doing the refactor