-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flaky decorator for tests with remote resources to reduce cold start failure rate. #700
Conversation
…ncidence of cold start related test failures
pytest.mark.flaky() decorator seems to work fine on my local machine but is causing CI issues - not quite sure why
Test failures on CI are resulting from FAILED tests/test_source.py::test_open_dataset_kerchunk - ValueError: Reference-FS's target filesystem must have same valueof asynchronous Investigating the cause now. |
Interesting... let me know what you find! I have not seen that before! |
e787d4d
to
fd60ed4
Compare
Weirdly enough, it consistently passes on 3.10, fails on 3.11 & 3.12. My local environment is 3.13 but on MacOS system. I'm gonna mark this as draft whilst I work on it - tests all pass locally, so I'm pretty stumped as to whats going on... |
Sounds good! I am working on Australian time this week and can review later... 👍 currently on travel to Tasmania... |
there is a chance this might be caused by it might be worth pinning the zarr requirements to versions earlier than v3 until we have a robust solution for dealing with the breaking changes in zarr v3. |
I've checked and my local & CI 3.10 are both on zarr==2.18.3, CI 3.11+ are on zarr 3. Pinning the deps now. |
29b3f40
to
86c05f9
Compare
Looks like this is ready to review now - @andersy005's zarr suggestion fixed the issue. I'm gonna see if I can use this same cold start trick to stop the documentation builds failing, so hopefully I'll drop that in too soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the fix!
Change Summary
@pytest.mark.flaky(max_runs=3, min_passes=1)
to test that request cloud resources. This should give cloud containers time to spin up if needed.Related issue number
#699
Checklist