Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for None in search query #612

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Add support for None in search query #612

merged 2 commits into from
Jun 19, 2023

Conversation

aulemahal
Copy link
Contributor

@aulemahal aulemahal commented Jun 16, 2023 •
edited
Loading

Change Summary

_search.search will use df[column].isnull() if column=None has been passed. np.NaN and pd.NA or anything that pd.isna(value) is suported.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

There are two added search tests because the case None was raising an error is QueryModel, while np.nan (which is a float) was not.

@aulemahal aulemahal requested a review from mgrover1 as a code owner June 16, 2023 21:48
@aulemahal aulemahal changed the title Add support for None NaN NA is search query - add tests Add support for None in search query Jun 16, 2023
andersy005
andersy005 approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, @aulemahal

mgrover1
mgrover1 approved these changes Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mgrover1 mgrover1 merged commit e6b49a8 into intake:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersy005 andersy005 andersy005 approved these changes

@mgrover1 mgrover1 mgrover1 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search for empty fields
3 participants
@aulemahal @andersy005 @mgrover1