Accept Path in esm_datastore #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast paths to string before passing to fsspec.
andersy005
approved these changes
Oct 19, 2022
andersy005
added
enhancement
|
It appears this PR is also impacted by the netCDF's thread safety issue reported in #548 |
|
@andersy005 - can we set the following
for now? |
|
That was mentioned in this issue Unidata/netcdf4-python#1192 and in the xarray repo pydata/xarray#7079 |
This has been fixed using the snippet I mentioned before... should be good for review |
mgrover1
approved these changes
Nov 16, 2022
|
thank you, @mgrover1 / @aulemahal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Cast paths to string before passing to fsspec.
Related issue number
Fixes #540.
Checklist