-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to_collection method returning an Xcollection #405
Conversation
for more information, see https://pre-commit.ci
In the tests we have
But an xc.Collection won't have |
@kmpaul This is failing with "Error: The process '/usr/share/miniconda3/condabin/mamba' failed with exit code 1" which seems to be the same as from the ProjectPythia pull requests (related to the new mamba version?). I'm looking for how you fixed that in those repositories now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error in protocol
Co-authored-by: Anderson Banihirwe <[email protected]>
Co-authored-by: Anderson Banihirwe <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Anderson Banihirwe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, @jukent! Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jukent!
Change Summary
Updating
to_dataset_dict
to return an xcollection.Collection object.Needed to addgit+git://github.com/NCAR/xcollection.git
to requirementsAnd wrap dictionaries in
xc.Collection
There are some uses of the word "Collection" throughout the file that are not an
xc.Collection
, we might want to be very specific with our language throughout.Tests seem to be unchanged by Collection vs Dictionary typing, maybe add an assert type test.
Related issue number
Collection
object implementation from NCAR/xcollection in intake-esm #382Checklist