Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for wrong signatures display #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pmos69
Copy link

@pmos69 pmos69 commented Oct 16, 2013

For signatures like "sensitive_data: sensitive data - eMail addresses" (sid:5 gid:138) squert was displaying the wrong description.

For signatures like "sensitive_data: sensitive data - eMail addresses" (sid:5 gid:138) squert was displaying the wrong description.
@int13h
Copy link
Owner

int13h commented Oct 16, 2013

As I was looking at your patch I was thinking 'that won't even fire' but it turns out the the check that is done earlier in that function is wrong, my intent was to stay out of that for loop completely if the GID was > 100 but with the <= it will run at least once :/

I want to re-check why I didn't want to process these GIDs before merging.

@pmos69
Copy link
Author

pmos69 commented Oct 17, 2013

:) looking at the code I thought the same thing, (that your intention was never to enter the loop).
Then I thought I might be missing something because that way these types of sigs would never display correctly.
Since I didn't want to end up looking like a jackass, I went for a quick&dirty fix again. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants