propsed fix for spikeglx streamer failing on SDSC because of wrong uuid in file name #905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, the Streamer was instantiated with a absolute path of the meta file (also not ideal in the context of the Streamers constructors call signature, where the first argument is named
sglx_file
and a dedicated argumentmeta_file
exists. link). While this looks like a bug, it is recovered there in the following lines under normal (=non-SDSC) usage as this linerecoveres the correct file paths.
However, this breaks on the SDSC as the file paths an uuid, and when the corresponding file path for the meta for the bin (or vice versa) are constructed, the uuid is wrong.
The proposed patch checks if the
.meta
filename contains an uuid, and if so, finds the correct uuid for the.cbin
file, constructs absolute paths for both. Either way, uuid or not, theStreamer
is now instantiated with both paths for.meta
and.bin
(or.cbin
).