Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Wheel extractor var names #854

Closed
k1o0 opened this issue Oct 4, 2024 · 0 comments
Closed

Rename Wheel extractor var names #854

k1o0 opened this issue Oct 4, 2024 · 0 comments
Assignees

Comments

@k1o0
Copy link
Contributor

k1o0 commented Oct 4, 2024

The var names are ambiguous in the Wheel extractor as outputs parts of trials, wheel, and wheelMoves objects. This may have lead to #853
https://github.com/int-brain-lab/ibllib/blob/develop/ibllib/io/extractors/training_wheel.py#L411-L412

Suggested changes:

var_names = ('wheel_timestamps', 'wheel_position', 'wheelMoves_intervals',
             'wheelMoves_peakAmplitude', 'wheelMoves_peakVelocity_times', 'trials_firstMovement_times',
             'trials_is_final_movement')
k1o0 added a commit that referenced this issue Oct 15, 2024
k1o0 added a commit that referenced this issue Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant