Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesoscope bad frames QC datasets incorrect #757

Closed
k1o0 opened this issue Apr 15, 2024 · 0 comments
Closed

Mesoscope bad frames QC datasets incorrect #757

k1o0 opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@k1o0
Copy link
Contributor

k1o0 commented Apr 15, 2024

There is a bug in the way the 'badframes' / 'exptQC' arrays are being read by the suite2p task. The reason for my suspicion is that in at least one session (SP035\2023-03-01\001) the original mat files (concatenated) don't correspond to the alf files that are output.
[...]
there are 3 consecutive bouts here. Could it be that the concatenation of the data is done in the wrong order? It looks to me like the resulting output is [2,1,0] rather than [0,1,2]?
[...]
If this is indeed the case this needs to be resolved asap and all suite2p tasks with >1 imaging bout need to be re-run. Right now the QC + badframes reported by the experimenter are not actually being taken into account for ROI detection in suite2p, so the ROIs can't be trusted. In fact I only looked into this because the ROIs in this particular session looked weird...

@k1o0 k1o0 added the bug Something isn't working label Apr 15, 2024
@k1o0 k1o0 self-assigned this Apr 15, 2024
k1o0 added a commit that referenced this issue Apr 15, 2024
@oliche oliche closed this as completed in d63e62b Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant