This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Draft: Add Control API on_start/on_stop callbacks #91
Draft
evdokimovs
wants to merge
253
commits into
master
Choose a base branch
from
on-start-on-stop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
# Conflicts: # src/signalling/room/command_handler.rs # src/signalling/room/dynamic_api.rs # src/signalling/room/mod.rs # src/signalling/room/peer_events_handler.rs # src/signalling/room/rpc_server.rs
# Conflicts: # src/api/control/refs/fid.rs # src/signalling/peers/media_traffic_state.rs # src/signalling/peers/metrics.rs # src/signalling/room/peer_events_handler.rs # src/signalling/room_service.rs
|
tyranron
changed the title
WIP: Add Control API on_start/on_stop callbacks
Draft: Add Control API on_start/on_stop callbacks
Aug 24, 2020
В связи с необходимостью предусмотреть возможность одновременной публикации нескольких видео-треков (видео с камеры + захват экрана), уточняем логику отправки коллбеков:
|
16 tasks
tyranron
force-pushed
the
master
branch
5 times, most recently
from
February 1, 2021 15:51
10e5ade
to
39716ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feature
New feature or request
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
k::monitoring
Related to monitoring capabilities
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27
Requires #90
Synopsis
We have
on_start
/on_stop
callbacks in theWebRtcPlayEndpoint
andWebRtcPublishEndpoint
in the Callback Control API. This PR implementson_start
on_stop
callbacks.This callbacks will rely firstly on client stats and for proofing that client doesn't lying we will check Coturn stats.
on_start
callback for theWebRtcPlayEndpoint
will be emitted when allMediaTrack
s ofPeerConnection
associated with this endpoint will start receiving traffic.on_start
callback for theWebRtcPublishEndpoint
will be emitted when at least onePeerConnection
(associated with this endpoint) will start sending traffic with all hisMediaTrack
s.E2E tests for this functional will be added in a another PR.
Solution
PeerConnection
stats, received from the Jasonon_start
by client statson_start
callbackChecklist
Draft:
prefixk::
labels appliedDraft:
prefix is removed