Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Draft: Refactor Rust to JS error propagation #214

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Draft: Refactor Rust to JS error propagation #214

wants to merge 9 commits into from

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Jul 30, 2021 •
edited
Loading

Synopsis

PR which refactors error propagation from Rust to JS. Now, instead of propagating generic JasonError, we will propagate object representing exact error type.

Solution

  1. Get rid of JasonError
  2. Propagate exception of the exact type instead of JasonError

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Jul 30, 2021
@evdokimovs evdokimovs added this to the 0.3.0 milestone Jul 30, 2021
@evdokimovs evdokimovs self-assigned this Jul 30, 2021
@evdokimovs evdokimovs marked this pull request as ready for review August 2, 2021 11:32
@evdokimovs
Copy link
Contributor Author

FCM

Refactor Rust to JS error propagation (#214)

- remove JasonError
- throw errors of the concrete types from WASM Jason

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa Awaiting requested review from alexlapa

Assignees
No one assigned
Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@evdokimovs @alexlapa