Loosen version requirement for OAuth gem #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions mainly include bug fixes, support newer Ruby versions, and partly drop support for older Ruby versions. Through the new version range specified with `>= 0.4.5`, we still allow the same OAuth gem version, but additionally allow all newer versions. Those do not contain any breaking changes. See https://gitlab.com/oauth-xx/oauth/-/blob/main/CHANGELOG.md
|
|
|
I will review on Monday and post feedback if any. Thanks so much! |
|
Sure, let me know if you have any questions, and I'll be happy to respond. Thanks again! |
|
@slaughter550 I would appreciate your review and a new version very much; this will unblock another gem update for me. Thanks again for your time! |
slaughter550
approved these changes
May 5, 2023
|
Awesome, thanks for merging. I would be grateful if you could drop a new release, making those changes available for everyone and easier integration with existing projects 🙏 |
|
@slaughter550 Would you mind drafting a new release with this change, please? If you'd like, I can prepare a PR with a version bump, as a first step of the release process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions mainly include bug fixes, support newer Ruby versions, and partly drop support for older Ruby versions. Through the new version range specified with
>= 0.4.5, we still allow the same OAuth gem version, but additionally allow all newer versions. Those do not contain any breaking changes.See https://gitlab.com/oauth-xx/oauth/-/blob/main/CHANGELOG.md
The changes I performed are similar to the ones discussed here by one of the OAuth gem maintainers. According to that discussion and my own analysis, newer versions of the OAuth gem do not contain any breaking changes.
@slaughter550: I would be happy if you could review my PR and potentially draft a new release -- thanks!