Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): adopt dataclass as config in component for type hinting #79

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Jan 9, 2024

Because

  • configure component config is counterintuitive

This commit

  • update bin/specs to support raw json-encoded string parsing
  • adopt schema generated dataclass as config input for creating component
  • support auto-gen task type
  • update readme, contributing guides and notebook

Copy link

linear bot commented Jan 9, 2024

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 280 lines in your changes are missing coverage. Please review.

Comparison is base (9b197a7) 16.74% compared to head (80992b6) 28.82%.

Files Patch % Lines
instill/resources/connector_airbyte.py 0.00% 194 Missing ⚠️
...urces/schema/openai_task_text_generation_output.py 0.00% 23 Missing ⚠️
...rces/schema/instill_task_text_generation_output.py 0.00% 20 Missing ⚠️
instill/resources/connector_data.py 39.13% 14 Missing ⚠️
instill/resources/schema/helper.py 22.22% 14 Missing ⚠️
instill/resources/connector_ai.py 30.00% 7 Missing ⚠️
...ill/resources/schema/numbers_task_commit_output.py 0.00% 6 Missing ⚠️
instill/resources/connector_blockchain.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #79       +/-   ##
===========================================
+ Coverage   16.74%   28.82%   +12.08%     
===========================================
  Files         166      170        +4     
  Lines        6516     6896      +380     
  Branches     1122     1133       +11     
===========================================
+ Hits         1091     1988      +897     
+ Misses       5408     4891      -517     
  Partials       17       17               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit 8c25bd1 into main Jan 9, 2024
10 checks passed
@heiruwu heiruwu deleted the INS-3299 branch January 9, 2024 19:44
heiruwu pushed a commit that referenced this pull request Jan 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.0...v0.6.0)
(2024-01-12)


### Features

* **connector,operator,component:** adopt jsonscema validation and
dataclass type hint
([#74](#74))
([0c47e51](0c47e51))
* **helpers:** add wrapper func for protobuf message
([#85](#85))
([279bd1e](279bd1e))
* **resource:** adopt dataclass as config in component for type hinting
([#79](#79))
([8c25bd1](8c25bd1))
* **resources:** support recipe update in pipeline resource
([#83](#83))
([89431fa](89431fa))


### Bug Fixes

* **resources:** fix resource schema path
([#76](#76))
([25f4418](25f4418))


### Documentation

* **notebook:** update notebook
([e5da642](e5da642))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

2 participants