Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ray): make model resource config private #132

Merged
merged 2 commits into from
Apr 10, 2024
Merged

refactor(ray): make model resource config private #132

merged 2 commits into from
Apr 10, 2024

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Apr 10, 2024

Because

  • we will not expose model resource config through model decorator

This commit

  • make resource config methods private
  • update default autoscaling config

@linear Linear
Copy link

linear bot commented Apr 10, 2024

INS-4149 restrict default model resource config in sdk

@heiruwu heiruwu merged commit 5c2bf34 into main Apr 10, 2024
7 checks passed
@heiruwu heiruwu deleted the heiru/INS-4149 branch April 10, 2024 16:24
heiruwu added a commit that referenced this pull request Apr 10, 2024
@heiruwu
refactor(ray): make model resource config private (#132)
2424e41 
Because

- we will not expose model resource config through model decorator

This commit

- make resource config methods private
- update default autoscaling config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @droplet-bot