Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helpers): add wrapper func for protobuf message #85

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Jan 12, 2024

Because

  • without directly provides protobuf message class in sdk, it's really hard to know what message structure is for users to implement a custom model

This commit

  • add wrapper func for protobuf message

Copy link

linear bot commented Jan 12, 2024

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (e5da642) 28.46% compared to head (96ce4a1) 28.15%.
Report is 1 commits behind head on main.

Files Patch % Lines
instill/helpers/protobufs/parse.py 0.00% 21 Missing ⚠️
instill/helpers/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   28.46%   28.15%   -0.31%     
==========================================
  Files         170      174       +4     
  Lines        6999     7075      +76     
  Branches     1139     1146       +7     
==========================================
  Hits         1992     1992              
- Misses       4990     5066      +76     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit 31e1f54 into main Jan 12, 2024
11 checks passed
@heiruwu heiruwu deleted the INS-3279 branch January 12, 2024 10:10
heiruwu added a commit that referenced this pull request Jan 12, 2024
Because

- without directly provides protobuf message class in sdk, it's really
hard to know what message structure is for users to implement a custom
model

This commit

- add wrapper func for protobuf message
heiruwu pushed a commit that referenced this pull request Jan 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.0...v0.6.0)
(2024-01-12)


### Features

* **connector,operator,component:** adopt jsonscema validation and
dataclass type hint
([#74](#74))
([0c47e51](0c47e51))
* **helpers:** add wrapper func for protobuf message
([#85](#85))
([279bd1e](279bd1e))
* **resource:** adopt dataclass as config in component for type hinting
([#79](#79))
([8c25bd1](8c25bd1))
* **resources:** support recipe update in pipeline resource
([#83](#83))
([89431fa](89431fa))


### Bug Fixes

* **resources:** fix resource schema path
([#76](#76))
([25f4418](25f4418))


### Documentation

* **notebook:** update notebook
([e5da642](e5da642))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

2 participants