Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipeline): add blob expiration time to run logs #938

Merged
merged 3 commits into from
Dec 16, 2024
Merged

feat(pipeline): add blob expiration time to run logs #938

merged 3 commits into from
Dec 16, 2024

Conversation

jvallesm
Copy link
Collaborator

Because

  • When the blob data associated to a pipeline / component run expires, the backend will stop serving it. It will be useful to both backend and clients to know that the data isn't there because it expired (instead of because an error occurred).

This commit

  • Adds a field with the blob data expiration data to the run entities.

@jvallesm jvallesm requested a review from donch1989 as a code owner December 13, 2024 14:59
@jvallesm jvallesm self-assigned this Dec 13, 2024
@linear Linear
Copy link

linear bot commented Dec 13, 2024

INS-7022 [Bug] Run logs show Completed status with no output or input

@jvallesm jvallesm force-pushed the jvalles/ins-7022-bug-run-logs-show-completed-status-with-no-output-or-input branch from 7e0dc1d to 21d27db Compare December 13, 2024 14:59
@jvallesm jvallesm force-pushed the jvalles/ins-7022-bug-run-logs-show-completed-status-with-no-output-or-input branch 2 times, most recently from 70c9eb6 to 825d56b Compare December 13, 2024 15:06
@jvallesm jvallesm force-pushed the jvalles/ins-7022-bug-run-logs-show-completed-status-with-no-output-or-input branch from 825d56b to 2ee6eb8 Compare December 13, 2024 15:08
donch1989
donch1989 previously approved these changes Dec 16, 2024
View reviewed changes
@jvallesm jvallesm merged commit fa7ef0e into main Dec 16, 2024
11 checks passed
@jvallesm jvallesm deleted the jvalles/ins-7022-bug-run-logs-show-completed-status-with-no-output-or-input branch December 16, 2024 18:01
@droplet-bot droplet-bot mentioned this pull request Dec 16, 2024
Merged
@jvallesm jvallesm mentioned this pull request Dec 17, 2024
Merged
jvallesm added a commit to instill-ai/instill-core that referenced this pull request Dec 17, 2024
@jvallesm
chore(helm): update pipeline database version (#1163)
f83ce23 
Because

- `pipeline-backend` added a new DB version in
instill-ai/pipeline-backend#938.

This commit

- Updates the version in the helm charts.
jvallesm pushed a commit that referenced this pull request Dec 17, 2024
@droplet-bot
chore(main): release 0.49.0-beta (#940)
97307f8 
🤖 I have created a release *beep* *boop*
---


##
[0.49.0-beta](v0.48.5-beta...v0.49.0-beta)
(2024-12-17)


### Features

* **pipeline:** add blob expiration time to run logs
([#938](#938))
([fa7ef0e](fa7ef0e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 left review comments

Assignees

@jvallesm jvallesm

Labels
instill component instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvallesm @donch1989 @droplet-bot