-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(vdp): upload raw inputs for run log (#904)
Because - now, the run log inputs are raw data but not blob storage - we want the inputs are download urls rather than dataURI This commit - move upload pipeline run inputs from worker to service - remove the worker upload inputs function - add the service upload inputs function
- Loading branch information
1 parent
b9298e5
commit 960f4c2
Showing
15 changed files
with
527 additions
and
281 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| package service | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/base64" | ||
| "fmt" | ||
| "mime" | ||
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/gabriel-vasile/mimetype" | ||
| "google.golang.org/grpc/metadata" | ||
|
|
||
| "github.com/instill-ai/pipeline-backend/pkg/recipe" | ||
| "github.com/instill-ai/pipeline-backend/pkg/resource" | ||
| "github.com/instill-ai/pipeline-backend/pkg/utils" | ||
|
|
||
| artifactpb "github.com/instill-ai/protogen-go/artifact/artifact/v1alpha" | ||
| resourcex "github.com/instill-ai/x/resource" | ||
| ) | ||
|
|
||
| func (s *service) uploadBlobAndGetDownloadURL(ctx context.Context, ns resource.Namespace, data string) (string, error) { | ||
| mimeType, err := getMimeType(data) | ||
| if err != nil { | ||
| return "", fmt.Errorf("get mime type: %w", err) | ||
| } | ||
| artifactClient := s.artifactPublicServiceClient | ||
| requesterUID, _ := resourcex.GetRequesterUIDAndUserUID(ctx) | ||
|
|
||
| vars, err := recipe.GenerateSystemVariables(ctx, recipe.SystemVariables{}) | ||
|
|
||
| if err != nil { | ||
| return "", fmt.Errorf("generate system variables: %w", err) | ||
| } | ||
|
|
||
| ctx = metadata.NewOutgoingContext(ctx, utils.GetRequestMetadata(vars)) | ||
|
|
||
| timestamp := time.Now().Format(time.RFC3339) | ||
| objectName := fmt.Sprintf("%s-%s%s", requesterUID.String(), timestamp, getFileExtension(mimeType)) | ||
|
|
||
| // TODO: We will need to add the expiry days for the blob data. | ||
| // This will be addressed in ins-6857 | ||
| resp, err := artifactClient.GetObjectUploadURL(ctx, &artifactpb.GetObjectUploadURLRequest{ | ||
| NamespaceId: ns.NsID, | ||
| ObjectName: objectName, | ||
| ObjectExpireDays: 0, | ||
| }) | ||
|
|
||
| if err != nil { | ||
| return "", fmt.Errorf("get upload url: %w", err) | ||
| } | ||
|
|
||
| uploadURL := resp.GetUploadUrl() | ||
| data = removePrefix(data) | ||
| b, err := base64.StdEncoding.DecodeString(data) | ||
| if err != nil { | ||
| return "", fmt.Errorf("decode base64 string: %w", err) | ||
| } | ||
|
|
||
| err = utils.UploadBlobData(ctx, uploadURL, mimeType, b, s.log) | ||
| if err != nil { | ||
| return "", fmt.Errorf("upload blob data: %w", err) | ||
| } | ||
|
|
||
| respDownloadURL, err := artifactClient.GetObjectDownloadURL(ctx, &artifactpb.GetObjectDownloadURLRequest{ | ||
| NamespaceId: ns.NsID, | ||
| ObjectUid: resp.GetObject().GetUid(), | ||
| }) | ||
| if err != nil { | ||
| return "", fmt.Errorf("get object download url: %w", err) | ||
| } | ||
|
|
||
| return respDownloadURL.GetDownloadUrl(), nil | ||
| } | ||
|
|
||
| func getMimeType(data string) (string, error) { | ||
| var mimeType string | ||
| if strings.HasPrefix(data, "data:") { | ||
| contentType := strings.TrimPrefix(data, "data:") | ||
| parts := strings.SplitN(contentType, ";", 2) | ||
| if len(parts) == 0 { | ||
| return "", fmt.Errorf("invalid data url") | ||
| } | ||
| mimeType = parts[0] | ||
| } else { | ||
| b, err := base64.StdEncoding.DecodeString(data) | ||
| if err != nil { | ||
| return "", fmt.Errorf("decode base64 string: %w", err) | ||
| } | ||
| mimeType = strings.Split(mimetype.Detect(b).String(), ";")[0] | ||
|
|
||
| } | ||
| return mimeType, nil | ||
| } | ||
|
|
||
| func getFileExtension(mimeType string) string { | ||
| ext, err := mime.ExtensionsByType(mimeType) | ||
| if err != nil { | ||
| return "" | ||
| } | ||
| if len(ext) == 0 { | ||
| return "" | ||
| } | ||
| return ext[0] | ||
| } | ||
|
|
||
| func removePrefix(data string) string { | ||
| if strings.HasPrefix(data, "data:") { | ||
| parts := strings.SplitN(data, ",", 2) | ||
| if len(parts) == 0 { | ||
| return "" | ||
| } | ||
| return parts[1] | ||
| } | ||
| return data | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.