Use autoselect control for Providers #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it matches both the Region and Consumers pickers. See #724
| :label-fn :label | ||
| :render-fn (fn [provider-set] [:div.option-row | ||
| [:span (:label provider-set)]])} | ||
| attrs)] | ||
| (when (asdf/should-reload? @list) |
There was a problem hiding this comment.
I don't know in which scenarios we should reload the list, but it was needed to at least load the options upon page load, so I kept this here.
There was a problem hiding this comment.
It's pretty usual to realize there's a providers source missing when you get to that screen so, if I get this right, it is good to have a reload after page load
mverzilli
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it matches both the Region and Consumers pickers.
See #724