Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to LabRecord Imports #319

Open
manumoreira opened this issue Aug 11, 2020 · 3 comments
Open

Add tags to LabRecord Imports #319

manumoreira opened this issue Aug 11, 2020 · 3 comments
Assignees
Labels
store (admin) Issues for maap-store admin

Comments

@manumoreira
Copy link
Contributor

manumoreira commented Aug 11, 2020

Add tags to categorize labrecord imports.
This tags will only be viewed and edited in the context of the store, none of this will be synchronized to the collector

@manumoreira manumoreira added the store (admin) Issues for maap-store admin label Aug 11, 2020
@manumoreira manumoreira changed the title Add tags to LabRecord Imports Add isDraft? checkbox to LabRecord Imports Nov 12, 2020
@manumoreira
Copy link
Contributor Author

This will require to enable edition for LabRecordImport it is critical to avoid enabling the deletion of LabRecordImports

@manumoreira manumoreira changed the title Add isDraft? checkbox to LabRecord Imports Add tags to LabRecord Imports Nov 12, 2020
@lmatayoshi
Copy link
Contributor

lmatayoshi commented Nov 17, 2020

Break down:

  • Add tags table and model
  • Add intermediate LabRecordImportTags table
  • Enable Tags section in ActiveAdmin with Index, New, Edit and Delete
  • Enable Edit interaction for LabRecordImports, which will allow only to add/remove tags

Details:

Tags table

id integer
name string

LabRecordImportsTags table

lab_record_imports_tags
lab_record_id integer
tag_id integer

@lmatayoshi
Copy link
Contributor

lmatayoshi commented Nov 24, 2020

@mmuller changes are listed in instedd/maap-store#88 (comment)

Let's test this by creating some tags, editing and deleting some few, and then going to the Lab Record Import list and adding tags to some imports.

Check permissions along the way: You should be able to perform any of the aforementioned actions as admin, whereas you shouldn't be able neither to see nor perform any modifying action as viewer.

Dropdown in Edit tags view is a standard select multiple HTML component with a pretty basic CSS and that's OK. We didn't want to spend much time styling it. However, what we should double check is the functionality. Tags that already belong to the LRI should start as selected, and you have to be able to select and deselect tags freely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
store (admin) Issues for maap-store admin
Projects
None yet
Development

No branches or pull requests

2 participants