Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [refactor] updated test file structure #29

Merged
merged 11 commits into from
Mar 9, 2021
Merged

Conversation

leeuwis
Copy link
Member

@leeuwis leeuwis commented Mar 5, 2021

Besides the test structure change, I want to get coverage up to 99%+

@leeuwis leeuwis requested a review from ggurkal March 5, 2021 17:10
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #29 (359a24d) into beta (ea0037a) will increase coverage by 9.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta      #29      +/-   ##
==========================================
+ Coverage   90.03%   99.04%   +9.00%     
==========================================
  Files          22       28       +6     
  Lines         281      314      +33     
  Branches       79       81       +2     
==========================================
+ Hits          253      311      +58     
+ Misses         28        3      -25     
Impacted Files Coverage Δ
lib/decorators/httpMethod.decorators.ts 100.00% <100.00%> (ø)
lib/exceptions/BadRequestException.ts 100.00% <100.00%> (ø)
lib/exceptions/InternalServerErrorException.ts 100.00% <100.00%> (ø)
lib/exceptions/NotFoundException.ts 100.00% <100.00%> (+60.00%) ⬆️
lib/exceptions/UnauthorizedException.ts 100.00% <100.00%> (ø)
lib/exceptions/UnprocessableEntityException.ts 100.00% <100.00%> (ø)
lib/exceptions/index.ts 100.00% <100.00%> (ø)
lib/internals/handler.ts 96.29% <100.00%> (+7.77%) ⬆️
lib/pipes/index.ts 100.00% <100.00%> (ø)
lib/pipes/parsers/index.ts 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca6370...bf27cac. Read the comment docs.

@leeuwis leeuwis linked an issue Mar 8, 2021 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
@leeuwis leeuwis requested a review from ggurkal March 9, 2021 09:39
@ggurkal ggurkal merged commit 81eb8b1 into beta Mar 9, 2021
@ggurkal ggurkal deleted the refactor/test-structure branch March 9, 2021 10:07
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🎉 This PR is included in version 1.3.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] add documentation for @Req and @Res decorators
2 participants