Scale method changed #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefsmeets
reviewed
Dec 19, 2023
Comment on lines
+118
to
+119
| max_row = np.argmax(img) // img.shape[1] | ||
| max_col = np.argmax(img) % img.shape[1] |
There was a problem hiding this comment.
Suggested change
| max_row = np.argmax(img) // img.shape[1] | |
| max_col = np.argmax(img) % img.shape[1] | |
| max_row, max_col = np.unravel_index(np.argmax(img), img.shape) |
stefsmeets
reviewed
Dec 19, 2023
Comment on lines
+120
to
+122
| for k in range(20): | ||
| for l in range(20): | ||
| img[max_row - k + 10][max_col - l + 10] = 1 |
There was a problem hiding this comment.
Suggested change
| for k in range(20): | |
| for l in range(20): | |
| img[max_row - k + 10][max_col - l + 10] = 1 | |
| img[max_row - 10: max_row + 10, max_col - 10: max_col + 10] = 1 |
|
Hi @Junschen1 thanks for the pull request. It seems like this finds the largest value over all images, but also sets a 20x20 window around the primary beam to 1. I just pushed a similar change yesterday: #82 Could you see if that works for you? |
|
I'm going to close this because of inactivity, feel free to re-open to update the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find the position of the strongest central spot and subtract its intensity to further determine the brightness of the strongest diffraction point