Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return individual rewards in Connector env #263

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

WiemKhlifi
Copy link
Contributor

What:

Return individual rewards from the Connector environment instead of providing the total sum of all agents' rewards. Additionally, implement all necessary changes to the test cases.

Extra:

Use the MultiToSingleWrapper to aggregate the reward and discount during the training process.

@WiemKhlifi WiemKhlifi self-assigned this Nov 13, 2024
@WiemKhlifi WiemKhlifi changed the title feat: return individual reward for each agent from connector feat: return individual rewards in Connector env Nov 13, 2024
sash-a
sash-a previously approved these changes Nov 13, 2024
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WiemKhlifi! Just revert the one file, I'll do it 😄

jumanji/training/configs/config.yaml Outdated Show resolved Hide resolved
@sash-a sash-a merged commit a8a4d3b into main Nov 15, 2024
4 checks passed
@sash-a sash-a deleted the feat/ma_connector branch November 15, 2024 07:59
jjakubassa pushed a commit to jjakubassa/jumanji that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants