Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /window must define handle first for Selenium 3.x and Firefox #119

Merged
merged 1 commit into from
Oct 28, 2022
Merged

POST /window must define handle first for Selenium 3.x and Firefox #119

merged 1 commit into from
Oct 28, 2022

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Oct 23, 2022

handle must be defined first (before name) to work in Selenium 3.x /w Firefox (as name is not supported by W3C, Chrome work /w and /wo this PR)

Selenium 2.x passing as well

please merge into 1.x branch and tag

@mvorisek mvorisek changed the title POST /window must define handle first for Selenium 3.x POST /window must define handle first for Selenium 3.x and Firefox Oct 23, 2022
@mvorisek
Copy link
Contributor Author

@robocoder can this be merged and released please?

robocoder added a commit that referenced this pull request Oct 28, 2022
* refs #119 - updating phpdocs for focusWindow
@robocoder robocoder merged commit a39a1f6 into instaclick:1.x Oct 28, 2022
@robocoder
Copy link
Member

Done. Thanks.

@mvorisek mvorisek deleted the fix_win_switch_w3c branch October 28, 2022 13:43
@robocoder
Copy link
Member

Note to self: this should have been backported from 2.0.0-BETA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants