New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error during legacy javascript execution #89

Closed

shavounet opened this issue Feb 13, 2019 · 0 comments

Contributor

shavounet commented Feb 13, 2019

Context

I'm trying to write some webdriver tests using behat and mink
mink requires this library in v1.4.5, but since it's not anymore compatible with current standards (see New WebDriver specification breaks element retrieval #80), I forced the upgrade to v2.0.0-RC2
from what I've seen, during a "wait", mink tries to execute the JS "return false" to see if the browser respond

Problem

The \WebDriver\Session::execute may have a parameter, but the func_get_arg(1) wrongfully take a non-existent second parameter
see

php-webdriver/lib/WebDriver/Session.php

Line 467 in 161f35e

$result = $this->curl('POST', '/execute', func_get_arg(1));
result : Warning: func_get_arg(): Argument 1 not passed to function in vendor/instaclick/php-webdriver/lib/WebDriver/Session.php line 468

The text was updated successfully, but these errors were encountered:

shavounet pushed a commit to shavounet/php-webdriver that referenced this issue


          Fixes instaclick#89

6e83a8d

shavounet mentioned this issue

Proposed fix for issue #89 #90

Merged

robocoder closed this as completed in

7047d4c

robocoder mentioned this issue

Session.php error in function execute() line 467 #94

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment