-
Notifications
You must be signed in to change notification settings - Fork 62
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixes #80 - support new WebDriver spec element ID
- Loading branch information
Showing
1 changed file
with
16 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be87042
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually patched this myself after needing 3 hours to figure out why firefox does not work and chrome does. Only then, when making the pull request, I saw that this is already in master. Could you please release that soon, either by releasing 2.0.0 or putting that patch back into a 1.4.6?
be87042
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cweiske 2.0.0-BETA tagged
be87042
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and a beta is never installed because most projects use stable dependency versions.
be87042
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the W3C WebDriver spec is still in flux (only a recommendation right now) and isn't widely implemented by other web drivers.
I'm open to creating a 1.x branch and backporting, but I don't have the time to do extensive regression testing with the translation layer enabled vs disabled.