Fix active record connection pool exhaustion #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repo Pull fixes from instacart repo
nickelser
approved these changes
Sep 14, 2020
|
|
||
| control_method :close, :steal!, :expire, :lease, :in_use?, :owner, :schema_cache, | ||
| :schema_cache=, :_run_checkin_callbacks, :_run_checkout_callbacks, :lock, :seconds_idle | ||
| control_method :close, :steal!, :expire, :lease, :in_use?, :owner, :schema_cache, :pool=, :pool, |
There was a problem hiding this comment.
might be worth documenting send_to_all vs control_method and the rationale here
|
I know it's been awhile but I too would like some insight into what the problem was and how this fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.