Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgis support #118

Merged
merged 2 commits into from
Aug 14, 2017
Merged

Conversation

choubacha
Copy link
Contributor

PostGIS is a very common extension for postgres for almost any company using locations and maps. It has it's own adapter which helps with the data typing of the geometries and preparing the database for postgis.

I've built a wrapper around the PostGIS adapter in the same vain as the postgresql adapter and written similar tests. For the tests, however, I'm only support ruby and AR 4.2+ since the postgis adapter setup is very different and prior to 4.2.

@lserman
Copy link

lserman commented Aug 11, 2016

@kbacha have you used this code in production? We are in need of PostGIS read replication and considering using your code.

@bleonard
Copy link
Contributor

bleonard commented Sep 8, 2016

thanks @kbacha - i know it's super delayed. this still working for you? any updates to make.

@lserman
Copy link

lserman commented Dec 7, 2016

@bleonard I saw you mentioned this is included in 0.3.7 on the PR, but I can't seem to find the connection adapter on Github. Was it added?

@MacTynow
Copy link

MacTynow commented Jul 25, 2017

@bleonard Is anybody still following this ? Is there any work that would need to be done to get this merged ?

@bleonard
Copy link
Contributor

I'm open to it. I was looking for someone actually using it in production and to get the tests updated, etc. Interested in helping out?

@choubacha
Copy link
Contributor Author

We were using it briefly and it seemed to work fine with postgix. However we had connection number issues and ended up moving to pg_pool and pg_bouncer to manage read/write segregation.

@MacTynow
Copy link

We are currently trying it out. I'll keep you updated with how it goes. @ankitagupta12, do you want to try to finish this ?

@MacTynow
Copy link

MacTynow commented Aug 4, 2017

@bleonard we are now using it in production since yesterday and things seem to be working fine. We just had an issue with the activerecord-import gem that we fixed by adding a custom adapter. I will try to find the time to work on this but I'm not the greatest ruby guy.

@bleonard
Copy link
Contributor

Great! The travis setiup has been updated since then. Can someone rebase from master and fix it up?

@choubacha
Copy link
Contributor Author

@bleonard I'll take a stab real quick.

@choubacha choubacha force-pushed the add-postgis-support branch from 0f9760f to c9bf4f9 Compare August 13, 2017 21:18
@choubacha
Copy link
Contributor Author

@bleonard Resolved the conflicts.

@bleonard bleonard merged commit 29a9ca5 into instacart:master Aug 14, 2017
@bleonard
Copy link
Contributor

Merged! And shipped! Thanks for the long journey.
https://rubygems.org/gems/makara/versions/0.3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants