global: uniform __future__ imports #108
Merged
+163
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spirosdelviniotis
force-pushed
the
hepcrawl_uniform_future_imports
branch
from
edb7b27 to
154e3b0
Compare
david-caro
force-pushed
the
hepcrawl_uniform_future_imports
branch
from
154e3b0 to
b8dc5cc
Compare
spirosdelviniotis
force-pushed
the
hepcrawl_uniform_future_imports
branch
from
b8dc5cc to
8ca5da2
Compare
spirosdelviniotis
force-pushed
the
hepcrawl_uniform_future_imports
branch
2 times, most recently
from
7012b6e to
58e6747
Compare
david-caro
suggested changes
May 11, 2017
hepcrawl/pipelines.py
Outdated
| import datetime | ||
| import json | ||
| import os | ||
|
|
||
| import requests | ||
|
|
||
| from crawler2hep import crawler2hep | ||
| from hepcrawl.crawler2hep import crawler2hep |
There was a problem hiding this comment.
from .crawler2hep import crawler2hep^ that means that it's importing from the current package, whatever the name of it is, the other, always imports from an 'installed' package called hepcrawl.
* Adds: uniform `__future__` imports. * Adds: update copyright year. * Removes: unused imports Closes inspirehep#103 Signed-off-by: Spiros Delviniotis <[email protected]>
spirosdelviniotis
force-pushed
the
hepcrawl_uniform_future_imports
branch
from
58e6747 to
b3126a8
Compare
|
@david-caro Ready! 💃 |
david-caro
approved these changes
May 11, 2017
| import os | ||
|
|
||
| import requests | ||
|
|
||
| from crawler2hep import crawler2hep | ||
|
|
||
| from .utils import get_temporary_file |
There was a problem hiding this comment.
I guess we left this when we removed the JsonWriter pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__future__imports.Closes #103
Signed-off-by: Spiros Delviniotis [email protected]