Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSP: fix local package crawling #106

Closed
spirosdelviniotis opened this issue May 3, 2017 · 0 comments · Fixed by #107
Closed

WSP: fix local package crawling #106

spirosdelviniotis opened this issue May 3, 2017 · 0 comments · Fixed by #107
Assignees
@spirosdelviniotis

Comments

@spirosdelviniotis
Copy link
Contributor

The mechanism of WSP spider that crawls from local stored folders (given a path) doesn't work for paths including files.

E.g: /path/to/file.zip works but /path/to/folder_with_zip_files/ doesn't.
@spirosdelviniotis spirosdelviniotis self-assigned this May 3, 2017
spirosdelviniotis added a commit to spirosdelviniotis/hepcrawl that referenced this issue May 3, 2017
@spirosdelviniotis
tests: adds WSP functional test for local package
48cc5ec 
* Adds WSP functional test for local package path.
* Refactored existing WSP functional test (add setup-teardown fixtures).
* Refactored `utils.ftp_list_files` to `utils.list_files` for reusability.
* Fixed WSP local package crawling mechanism.

Closes inspirehep#106

Signed-off-by: Spiros Delviniotis <[email protected]>
@spirosdelviniotis spirosdelviniotis mentioned this issue May 3, 2017
Merged
@ghost ghost added the Status: WIP label May 3, 2017
david-caro pushed a commit to spirosdelviniotis/hepcrawl that referenced this issue May 9, 2017
@spirosdelviniotis @david-caro
tests: adds WSP functional test for local package
76c79cc 
* Adds WSP functional test for local package path.
* Refactored existing WSP functional test (add setup-teardown fixtures).
* Refactored `utils.ftp_list_files` to `utils.list_files` for reusability.
* Fixed WSP local package crawling mechanism.

Closes inspirehep#106

Signed-off-by: Spiros Delviniotis <[email protected]>
spirosdelviniotis added a commit to spirosdelviniotis/hepcrawl that referenced this issue May 10, 2017
@spirosdelviniotis
tests: adds WSP functional test for local package
7a40c66 
* Adds WSP functional test for local package path.
* Refactored existing WSP functional test (add setup-teardown fixtures).
* Refactored `utils.ftp_list_files` to `utils.list_files` for reusability.
* Fixed WSP local package crawling mechanism.

Closes inspirehep#106

Signed-off-by: Spiros Delviniotis <[email protected]>
spirosdelviniotis added a commit to spirosdelviniotis/hepcrawl that referenced this issue May 10, 2017
@spirosdelviniotis
tests: adds WSP functional test for local package
81edfed 
* Adds WSP functional test for local package path.
* Refactored existing WSP functional test (add setup-teardown fixtures).
* Refactored `utils.ftp_list_files` to `utils.list_files` for reusability.
* Fixed WSP local package crawling mechanism.

Closes inspirehep#106

Signed-off-by: Spiros Delviniotis <[email protected]>
spirosdelviniotis added a commit to spirosdelviniotis/hepcrawl that referenced this issue May 10, 2017
@spirosdelviniotis
tests: adds WSP functional test for local package
8c9fab2 
* Adds WSP functional test for local package path.
* Refactored existing WSP functional test (add setup-teardown fixtures).
* Refactored `utils.ftp_list_files` to `utils.list_files` for reusability.
* Fixed WSP local package crawling mechanism.

Closes inspirehep#106

Signed-off-by: Spiros Delviniotis <[email protected]>
spirosdelviniotis added a commit to spirosdelviniotis/hepcrawl that referenced this issue May 10, 2017
@spirosdelviniotis
tests: adds WSP functional test for local package
1303c08 
* Adds WSP functional test for local package path.
* Refactored existing WSP functional test (add setup-teardown fixtures).
* Refactored `utils.ftp_list_files` to `utils.list_files` for reusability.
* Fixed WSP local package crawling mechanism.

Closes inspirehep#106

Signed-off-by: Spiros Delviniotis <[email protected]>
spirosdelviniotis added a commit to spirosdelviniotis/hepcrawl that referenced this issue May 11, 2017
@spirosdelviniotis
tests: adds WSP functional test for local package
94af814 
* Adds WSP functional test for local package path.
* Refactored existing WSP functional test (add setup-teardown fixtures).
* Refactored `utils.ftp_list_files` to `utils.list_files` for reusability.
* Fixed WSP local package crawling mechanism.

Closes inspirehep#106

Signed-off-by: Spiros Delviniotis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spirosdelviniotis spirosdelviniotis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: adds WSP functional test for local package spirosdelviniotis/hepcrawl
1 participant
@spirosdelviniotis