Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making HttpInMetricTest more reliable against failure #883

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Making HttpInMetricTest more reliable against failure #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ...nt/src/system-test/java/rocks/inspectit/ocelot/instrumentation/http/HttpInMetricTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,8 @@
*/
public class HttpInMetricTest {

public static final int PORT = 9999;

private Server server;


void fireRequest(String url) {
try {
HttpURLConnection urlConnection = (HttpURLConnection) new URL(url).openConnection();
Expand All @@ -48,16 +45,14 @@ public static class TestServlet extends HttpServlet {
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
resp.setStatus(123);
}

}

@Nested
class ServletAPI {

@Test
void testRequestRecorded() throws Exception {

server = new Server(PORT);
server = new Server(0);
ServletHandler servletHandler = new ServletHandler();
server.setHandler(servletHandler);
servletHandler.addServletWithMapping(TestServlet.class, "/*");
Expand All @@ -66,9 +61,10 @@ void testRequestRecorded() throws Exception {
TestUtils.waitForClassInstrumentations(Arrays.asList(HttpServlet.class,
Class.forName("sun.net.www.protocol.http.HttpURLConnection")), 10, TimeUnit.SECONDS);

fireRequest("http://localhost:" + PORT + "/servletapi");
fireRequest("http://localhost:" + server.getURI().getPort() + "/servletapi");
server.stop();

TestUtils.waitForOpenCensusQueueToBeProcessed();

Map<String, String> tags = new HashMap<>();
tags.put("http_path", "/servletapi");
Expand Down