Closes #824 - Added API for kapacitor tasks #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderWert
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JonasKunz)
components/inspectit-ocelot-configurationserver/src/main/java/rocks/inspectit/ocelot/rest/alert/kapacitor/model/TemplateVariable.java, line 43 at r1 (raw file):
* It references a topic, to which the alerts will be sent. */ public static final String TOPIC_VARIABLE = "topic";
we should use the same name schema for this special variable as for the other two above
AlexanderWert
added a commit
that referenced
this pull request
Jul 28, 2020
* Implementation of an alerting UI for the configuration server (#840) * Closes #811 - Created UI for alert rule configuration * Closes #811 - fixed lint errors * Closes #811 - fixed bug in default prop values * Closes #811 - created grouping options * reverted yarn lock upgrade * refactoring of the alerting tree * refactored alerting rules toolbars * Rule view refactoring * resolved proptypes warning and prevented flickering * added status to rule view * Fixed formatting and lint errors * Closes #810 - Added REST-API for kapacitor templates (#827) * Closes #810 - Added REST-API for kapacitor templates * Review fixes * Closes #824 - Added API for kapacitor tasks (#862) * Closes #849: Alerting UI - Topics (#850) * Closes #825 - Added API for kapacitor topics and handlers (#863) * Closes #861: Binding Alerting UI to REST API (#868) Co-authored-by: Alexander Wert <[email protected]> Co-authored-by: Marius Oehler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #824
This change is