Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed occasional duplicate injection of correlation Headers #797

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

JonasKunz
Copy link
Member

@JonasKunz JonasKunz commented Jun 30, 2020

This change is Reviewable

mariusoe
mariusoe previously approved these changes Jun 30, 2020
Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #797 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #797      +/-   ##
============================================
- Coverage     83.00%   82.97%   -0.04%     
+ Complexity     1736     1734       -2     
============================================
  Files           174      174              
  Lines          5366     5366              
  Branches        650      650              
============================================
- Hits           4454     4452       -2     
- Misses          675      679       +4     
+ Partials        237      235       -2     
Impacted Files Coverage Δ Complexity Δ
...bootstrap/instrumentation/noop/NoopMethodHook.java 33.33% <0.00%> (-66.67%) 1.00% <0.00%> (-2.00%)
...tit/ocelot/bootstrap/context/noop/NoopContext.java 0.00% <0.00%> (-9.09%) 0.00% <0.00%> (-1.00%)
...ysources/EnvironmentInformationPropertySource.java 61.29% <0.00%> (-6.45%) 9.00% <0.00%> (-1.00%)
.../ocelot/core/instrumentation/hook/HookManager.java 90.54% <0.00%> (+1.35%) 8.00% <0.00%> (ø%)
...ot/core/instrumentation/AsyncClassTransformer.java 87.96% <0.00%> (+1.85%) 32.00% <0.00%> (+2.00%)

Copy link
Member Author

@JonasKunz JonasKunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@JonasKunz JonasKunz merged commit e7890a0 into inspectIT:master Jun 30, 2020
@JonasKunz JonasKunz deleted the urlconn-propagation branch June 30, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants