Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #746 - Added extension point for globally adding trace attributes #747

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

JonasKunz
Copy link
Member

@JonasKunz JonasKunz commented May 20, 2020

Closes #746


This change is Reviewable

Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @JonasKunz)

a discussion (no related file):
I think the r_httpurlconnection_tracing_start rule should also include at least the r_tracing_global_attributes rule or the the r_http_tracing_default_attributes one?



inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/instrumentation/rules/_shared/tracing.yml, line 10 at r1 (raw file):

stack-trace

Do you get the stack-trace? Isn't it just the exception class/name?


inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/instrumentation/rules/db/jdbc/tracing.yml, line 42 at r1 (raw file):

          'r_jdbc_extract_url': true
          'r_tracing_global_attributes': true
          'r_tracing_exception_attributes': true

Not also the FQN?


inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/instrumentation/rules/http/_shared/http-tracing.yml, line 35 at r1 (raw file):

      'r_http_tracing_default_attributes':
        include:
          'r_tracing_global_attributes': true

Why not also the FQN and exception?

Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mariusoe mariusoe merged commit a28378f into inspectIT:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an extension point for defining global trace attributes
2 participants