Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default session-id-header for tags-http-exporter #1620

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

EddeCCC
Copy link
Member

@EddeCCC EddeCCC commented Sep 27, 2023

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1620 (37d8cfb) into master (61429e4) will decrease coverage by 0.02%.
The diff coverage is 35.00%.

❗ Current head 37d8cfb differs from pull request most recent head 48043ec. Consider uploading reports for the commit 48043ec to get more accurate results

@@             Coverage Diff              @@
##             master    #1620      +/-   ##
============================================
- Coverage     78.39%   78.37%   -0.02%     
- Complexity     2518     2519       +1     
============================================
  Files           257      257              
  Lines          8247     8256       +9     
  Branches        983      984       +1     
============================================
+ Hits           6465     6470       +5     
- Misses         1355     1359       +4     
  Partials        427      427              
Files Coverage Δ
...ntation/browser/BrowserPropagationDataStorage.java 89.29% <100.00%> (+0.40%) ⬆️
...on/context/propagation/BrowserPropagationUtil.java 58.82% <50.00%> (ø)
...xporter/BrowserPropagationHttpExporterService.java 36.96% <0.00%> (ø)
...celot/core/exporter/BrowserPropagationServlet.java 93.33% <44.44%> (-1.03%) ⬇️
...tion/browser/BrowserPropagationSessionStorage.java 67.74% <0.00%> (-10.04%) ⬇️

... and 1 file with indirect coverage changes

@EddeCCC EddeCCC requested a review from TitusLabs September 27, 2023 09:21
Copy link
Contributor

@TitusLabs TitusLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EddeCCC)

@EddeCCC EddeCCC merged commit a4e425a into master Oct 9, 2023
8 checks passed
@EddeCCC EddeCCC deleted the update-tags-exporter-docu branch November 8, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants