Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends the agent with a debug function to trace its action calls #1484

Merged
merged 12 commits into from
Jul 12, 2022

Conversation

mariusoe
Copy link
Member

@mariusoe mariusoe commented Jun 22, 2022

This PR extends the agent by a debug functionallity to trace its aciton calls incl. the respective method hook. This can be used to debug configurations and to understand what the agent is acutally doing. The spans representing the action calls will include context information like action arguments, return values and information about the data context an action is executed in.

Jaeger_UI


This change is Reviewable

@mariusoe mariusoe added enhancement New feature or request area/agent labels Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1484 (96df1bf) into master (14c48b6) will decrease coverage by 0.57%.
The diff coverage is 60.22%.

@@             Coverage Diff              @@
##             master    #1484      +/-   ##
============================================
- Coverage     79.20%   78.63%   -0.57%     
- Complexity     2250     2269      +19     
============================================
  Files           230      232       +2     
  Lines          7292     7426     +134     
  Branches        867      887      +20     
============================================
+ Hits           5775     5839      +64     
- Misses         1159     1220      +61     
- Partials        358      367       +9     
Impacted Files Coverage Δ
...inspectit/ocelot/config/model/InspectitConfig.java 100.00% <ø> (ø)
...rumentation/rules/InstrumentationRuleSettings.java 100.00% <ø> (ø)
.../actions/bound/ConstantOnlyBoundGenericAction.java 100.00% <ø> (ø)
...ation/actions/bound/DynamicBoundGenericAction.java 89.47% <ø> (ø)
...on/actions/template/VoidGenericActionTemplate.java 0.00% <ø> (ø)
...nstrumentation/hook/actions/TracingHookAction.java 0.00% <0.00%> (ø)
...core/instrumentation/hook/MethodHookGenerator.java 85.83% <44.44%> (-6.62%) ⬇️
...t/ocelot/core/instrumentation/hook/MethodHook.java 72.60% <50.00%> (-22.52%) ⬇️
...trumentation/actions/bound/BoundGenericAction.java 85.71% <80.00%> (-1.79%) ⬇️
...core/instrumentation/hook/ActionCallGenerator.java 95.00% <85.71%> (-5.00%) ⬇️
... and 9 more

@mariusoe mariusoe marked this pull request as ready for review June 23, 2022 14:39
Copy link
Contributor

@ClaudioWaldvogel ClaudioWaldvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 58 of 58 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mariusoe)

@ClaudioWaldvogel ClaudioWaldvogel merged commit f19a426 into inspectIT:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants