Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1434: Fix Divergence of Documentation for Default Config and Default Config itself #1435

Merged

Conversation

heiko-holz
Copy link
Contributor

@heiko-holz heiko-holz commented May 16, 2022

Closes #1434


This change is Reviewable

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1435 (cc1b022) into master (63ee502) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1435      +/-   ##
============================================
+ Coverage     79.16%   79.17%   +0.01%     
  Complexity     2234     2234              
============================================
  Files           232      232              
  Lines          7240     7240              
  Branches        859      859              
============================================
+ Hits           5731     5732       +1     
  Misses         1153     1153              
+ Partials        356      355       -1     
Impacted Files Coverage Δ
...nspectit/ocelot/core/utils/HighPrecisionTimer.java 90.62% <0.00%> (+1.56%) ⬆️

Copy link
Member

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @heiko-holz and @MariusBrill)


inspectit-ocelot-documentation/docs/metrics/metric-exporters.md line 87 at r2 (raw file):

| Property    | Default    | Description                                                                                                                                                                     |
| ----------- |------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `.enabled`  | `DISABLED` | If `ENABLED` or `IF_CONFIGURED`, the inspectIT Ocelot agent will try to start the OTLP gRPC metrics exporter.                                                                   |

Isn't the default-value here "IF_CONFIGURED" ? (https://github.com/inspectIT/inspectit-ocelot/blob/master/inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/exporters.yml)

Copy link
Contributor Author

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @MariusBrill)


inspectit-ocelot-documentation/docs/metrics/metric-exporters.md line 87 at r2 (raw file):

Previously, MariusBrill (Marius Brill) wrote…

Isn't the default-value here "IF_CONFIGURED" ? (https://github.com/inspectIT/inspectit-ocelot/blob/master/inspectit-ocelot-config/src/main/resources/rocks/inspectit/ocelot/config/default/exporters.yml)

Yes, thanks for spotting this.
I fixed this.

Copy link
Member

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @heiko-holz)

@MariusBrill MariusBrill merged commit 50302f5 into inspectIT:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Fix Divergence of Documentation for Default Config and Default Config itself
2 participants